[coreboot] typo in amdk8/raminit_f.c

ron minnich rminnich at gmail.com
Mon Apr 13 18:12:39 CEST 2009


That's a fine catch. I guess we'll have to have some testing done on
this never-used piece of code.

I'm puzzled that it did not get an error. Anybody know shy? It was not
an #ifdef, it was a #if.

I think this is one reason the Bell Labs crowd started using:
if (preprocessor_symbol == value)

instead of this:
#if preprocessor_symbol == value

That's the C compilers job, after all ...

The more code I see, the more I agree with them.

ron




More information about the coreboot mailing list