[coreboot] [PATCH] v2: abuild: Add -r|--remove option to abuild

Stefan Reinauer stepan at coresystems.de
Wed Apr 15 18:53:48 CEST 2009


Pardon my last mail.. I completely missed the point. The option is 
indeed _very_ useful. Please don't back out.

Uwe Hermann schrieb:
> On Thu, Dec 18, 2008 at 01:41:54AM +0100, Peter Stuge wrote:
>   
>> Uwe Hermann wrote:
>>     
>>> Add -r|--remove option to force abuild to remove the output directory
>>> after every board build, in order to save disk space if you don't need
>>> the actual output files.
>>>
>>> Signed-off-by: Uwe Hermann <uwe at hermann-uwe.de>
>>>       
>> See below.
>>
>> Acked-by: Peter Stuge <peter at stuge.se>
>>     
>
> Thanks, long-overdue commit in r4119 (build-tested again today to make
> sure nothing broke in the mean time).
>
>
>   
>>> +	VENDOR=$1
>>> +	MAINBOARD=$2
>>>       
>> Request "${1}" and "${2}"
>>
>>
>>     
>>> +	if [ "$remove" == "true" ]; then
>>>       
>> Should this really be == and not just a single = ?
>>
>>
>>     
>>> +		printf "Removing build dir for board $VENDOR $MAINBOARD...\n"
>>> +		rm -rf $TARGET/${VENDOR}_${MAINBOARD}
>>>       
>> Likewise request "${TARGET}/${VENDOR}_${MAINBOARD}"
>>     
>
> Will look into these issues and test/fix them in a separate patch.
>
>
> Uwe.
>   





More information about the coreboot mailing list