[coreboot] Config.lb includes

Myles Watson mylesgw at gmail.com
Fri Apr 17 19:38:05 CEST 2009


On Fri, Apr 17, 2009 at 11:15 AM, Stefan Reinauer <stepan at coresystems.de> wrote:
> Myles Watson schrieb:
>>
>> On Fri, Apr 17, 2009 at 10:28 AM, ron minnich <rminnich at gmail.com> wrote:
>>
>>>
>>> On Fri, Apr 17, 2009 at 9:25 AM, Myles Watson <mylesgw at gmail.com> wrote:
>>>
>>>
>>>>
>>>> Not really.  I guess I couldn't tell from Carl-Daniel's request what
>>>> exactly he wanted.  I thought this would be enough to let him make
>>>> something work.  I admit it was quick and dirty.  It could be easily
>>>> changed to take a path instead of a string.
>>>>
>>>
>>> Since you are up to speed on the config tool, and know how to improve
>>> it :-), I'd like to request a general purpose include command instead
>>> (or see if there is already one in there I forgot about :-)
>>>
>>
>> I didn't find one when I looked.  I think it would be hard to make one
>> that worked in targets/*/*/Config.lb files and src/.../Config.lb
>> files, but I guess no one has asked for that.
>>
>> How general are you thinking?  I'm probably willing to do this:
>>
>> include acpi.lb
>>
>> include /acpi.lb
>>
>> Where acpi.lb includes from the current directory and /acpi.lb
>> includes from /src/acpi.lb
>>
>
> Whats wrong with the "dir" command?
>
> Especially since we're working on getting rid of Config.lb in favor of
> Kconfig..

I think the idea was a little more flexibility.  If it is going away
soon it should be fine to let cleanups happen.  Hopefully they'll
speed up the conversion to Kconfig when it happens.

This include is very simple and related to the dir command.

Implemented with relative and absolute paths.

Signed-off-by: Myles Watson <mylesgw at gmail.com>

Thanks,
Myles

Myles
-------------- next part --------------
A non-text attachment was scrubbed...
Name: include_files.diff
Type: text/x-patch
Size: 1767 bytes
Desc: not available
URL: <http://www.coreboot.org/pipermail/coreboot/attachments/20090417/23a6fca0/attachment.diff>


More information about the coreboot mailing list