[coreboot] [flashrom][PATCH] typo in Makefile

Carl-Daniel Hailfinger c-d.hailfinger.devel.2006 at gmx.net
Fri Apr 24 15:04:27 CEST 2009


On 24.04.2009 14:16, Ward Vandewege wrote:
> On Fri, Apr 24, 2009 at 11:15:07AM +0200, stephan.guilloux at free.fr wrote:
>   
>>>> Found some typo in Makefile which was producing some "strange behaviours"
>>>>         
>>> while
>>>       
>>>> compiling pciutils rule.
>>>>
>>>>
>>>>         
>>> Can you enlighten us about the strangeness of that behavior? ;-)
>>>
>>> Stefan
>>>       
>> steph-laptop:~/Work/Flashrom/flashrom> make pciutils
>>
>> Checking for pciutils and zlib... found.
>> steph-laptop:~/Work/Flashrom/flashrom> make pciutils
>>
>> Checking for pciutils and zlib... found.
>> steph-laptop:~/Work/Flashrom/flashrom> cc1: erreur: .test.c : Aucun fichier ou
>> dossier de ce type
>> steph-laptop:~/Work/Flashrom/flashrom> make pciutils
>>
>> Checking for pciutils and zlib... found.
>> steph-laptop:~/Work/Flashrom/flashrom> gcc: .test.c : Aucun fichier ou dossier
>> de ce type
>>     
>
> Yes, I've seen that happen too, but never investigated.
>
>   
>> Regarding the fix, as discussed on #coreboot, ">&" is used to redirect both CC's
>> stdin and stdout to /dev/null.
>> 	@$(CC) $(CFLAGS) .test.c -o .test $(LDFLAGS) >& /dev/null &&
>>     
>
> Yes, you're right.
>   

I originally insisted on >& because it worked on tcsh, but since make
uses /bin/sh and /bin/sh has to be POSIX compliant, we can use the POSIX
variant. >& is not POSIX compliant, but
 >/dev/null 2>&1
is POSIX compliant. This is specified in SuSv3, Shell command language,
sections 2.7.2 and 2.7.6.

>>>> Signed-off-by: Stephan Guilloux <stephan.guilloux at free.fr>
>>>>         
>
> Acked-by: Ward Vandewege <ward at gnu.org>
>   

Stephan, would you mind resubmitting the 2>&1 variant? Thanks.


Regards,
Carl-Daniel

-- 
http://www.hailfinger.org/





More information about the coreboot mailing list