[coreboot] [PATCH]The resource allocator does not like zero-sized fixed resources

Patrick Georgi patrick at georgi-clan.de
Wed Aug 19 19:32:41 CEST 2009


Am 19.08.2009 19:08, schrieb Myles Watson:
> The example you gave in src/devices/pci_device.c was for the old way of
> specifying PCI ROM locations.  Now that CBFS is going mainstream, that
> should disappear.  If it doesn't, I think it should have a size.  Even 1
> would work, since no Option ROM can be smaller than that.
>    
I'd love to get rid of the rom_address thing once we drop the pre-cbfs 
way of doing things (which will take quite some time, still), but I'm 
not sure if there isn't some need for it left.
> What other fixed resources have 0 size, especially on Kontron?  I'd like to
> fix the root cause.
>    
That's the only one on Kontron. I just wanted to have proper behaviour 
even with such weird entries.


Patrick




More information about the coreboot mailing list