[coreboot] Trying to add Kconfig support for M57SLI - build error

Harald Gutmann harald.gutmann at gmx.net
Thu Aug 20 22:56:16 CEST 2009


Hello,

recently I'm trying to add Kconfig support to the M57SLI board from gigabyte, 
but right now i stumbled into an error where I can't figure out what is wrong.

This problem is not directly related to Kconfig, but it seems that I 
misunderstand something in the compiler errors, or that I'm not able to fix 
this one.

The log of make:

hargut at benchvice:~/cb-v2$ make
    GEN        build/build.h
    CC         build/northbridge/amd/amdk8/misc_control.o
In file included from src/northbridge/amd/amdk8/amdk8.h:6,
                 from src/northbridge/amd/amdk8/misc_control.c:22:
src/northbridge/amd/amdk8/amdk8_f.h:524:21: error: macro "hard_reset" passed 1 
arguments, but takes just 0
src/northbridge/amd/amdk8/misc_control.c: In function ‘mcf3_read_resources’:
src/northbridge/amd/amdk8/misc_control.c:51: warning: passing argument 2 of 
‘get_option’ discards qualifiers from pointer target type
src/northbridge/amd/amdk8/misc_control.c: In function ‘misc_control_init’:
src/northbridge/amd/amdk8/misc_control.c:113: warning: unused variable 
‘f2_dev’
make: *** [/home/hargut/cb-v2/build/northbridge/amd/amdk8/misc_control.o] 
Error 1
hargut at benchvice:~/cb-v2$ grep hard_reset 
src/northbridge/amd/amdk8/misc_control.c
#include <part/hard_reset.h>
                hard_reset();
hargut at benchvice:~/cb-v2$ grep hard_reset src/northbridge/amd/amdk8/amdk8_f.h
void hard_reset(void);
                hard_reset();
hargut at benchvice:~/cb-v2$

EOL (End of Log)

The error itself is:
src/northbridge/amd/amdk8/amdk8_f.h:524:21: error: macro "hard_reset" passed 1 
arguments, but takes just 0

but where gets the hard_reset passed one argument?
And or why is hard_reset used as in line 23 of cache_as_ram_auto.c there is 
the "#define __ROMCC__" which should cause that soft_reset() in amdk8_f.h is 
used.

"#ifdef __ROMCC__
static void soft_reset(void);
#else
void hard_reset(void);
#endif"

What of that stuff do I misunderstand that I'm not able to fix that compilation 
error? Or am I unable to see the wood because of so much trees?

Many thanks for any tips on solving that error/understanding problem.

Kind regards,
Harald




More information about the coreboot mailing list