[coreboot] [commit] r4982 - in trunk/util: compareboard kbuildall

svn at coreboot.org svn at coreboot.org
Fri Dec 18 11:20:15 CET 2009


Author: stepan
Date: 2009-12-18 11:20:15 +0100 (Fri, 18 Dec 2009)
New Revision: 4982

Modified:
   trunk/util/compareboard/compareboard
   trunk/util/kbuildall/kbuildall
Log:
- speed up board comparison by only building abuild configs, not the whole
  target.
- use a template for mktemp (fixes OSX error)
- convert all numbers to hex to make comparison easier.

Signed-off-by: Stefan Reinauer <stepan at coresystems.de>
Acked-by: Stefan Reinauer <stepan at coresystems.de>



Modified: trunk/util/compareboard/compareboard
===================================================================
--- trunk/util/compareboard/compareboard	2009-12-17 18:47:50 UTC (rev 4981)
+++ trunk/util/compareboard/compareboard	2009-12-18 10:20:15 UTC (rev 4982)
@@ -16,7 +16,7 @@
 
 BOARDPATH=`echo $1 | sed s,/,_,g`
 
-A=`mktemp`
+A=`mktemp tmp.XXXXXXXXXX`
 rm -rf $A
 mkdir -p $A
 
@@ -92,6 +92,15 @@
 normalize $A/old.filtered > $A/old.normalized
 normalize $A/new.filtered > $A/new.normalized
 
-diff -u $A/old.normalized $A/new.normalized |grep ^[+-][^+-]|sed -e "s,^+,p ," -e "s,^-,m ," |sort -k2,2 -k1,1 |sed -e "s,^p ,+," -e "s,^m ,-,"
+diff -u $A/old.normalized $A/new.normalized | \
+    grep ^[+-][^+-] | \
+    sed -e "s,^+,p ," -e "s,^-,m ," | \
+    sort -k2,2 -k1,1 | \
+    sed -e "s,^p ,+," -e "s,^m ,-," | \
+    while read line; do
+	key=`echo $line|cut -f1 -d\=`
+	value=`echo $line|cut -f2 -d\= | tr -d \\;`
+	printf "%s = 0x%x\n" "$key" $value
+    done
 
 rm -rf $A

Modified: trunk/util/kbuildall/kbuildall
===================================================================
--- trunk/util/kbuildall/kbuildall	2009-12-17 18:47:50 UTC (rev 4981)
+++ trunk/util/kbuildall/kbuildall	2009-12-18 10:20:15 UTC (rev 4982)
@@ -61,7 +61,7 @@
 	result=`$MAKE > $TARGETDIR/$name.buildcoreboot.log 2>&1 && echo ok || echo fail`
 	echo "$result."
 	if [ "$result" = "ok" ]; then
-		util/abuild/abuild -t $dir
+		util/abuild/abuild -C -t $dir
 		sh util/compareboard/compareboard $dir | tee $TARGETDIR/$name.variables.txt
 	fi
 	echo "$dir $result" >> $TARGETDIR/_overview.txt





More information about the coreboot mailing list