[coreboot] [PATCH]some more kconfig

Myles Watson mylesgw at gmail.com
Fri Dec 18 19:50:17 CET 2009


On Fri, Dec 18, 2009 at 11:43 AM, Stefan Reinauer <stepan at coresystems.de>wrote:

> On 12/18/09 5:56 PM, Peter Stuge wrote:
> > Patrick Georgi wrote:
> >
> >> +++ src/mainboard/kontron/986lcd-m/Kconfig   (working copy)
> >> @@ -6,15 +6,22 @@
> >>      select NORTHBRIDGE_INTEL_I945
> >>      select SOUTHBRIDGE_INTEL_I82801GX
> >>      select SUPERIO_WINBOND_W83627THG
> >> -    select HAVE_PIRQ_TABLE
> >> -    select HAVE_MP_TABLE
> >> +    select GENERATE_ACPI_TABLES
> >> +    select GENERATE_PIRQ_TABLE
> >> +    select GENERATE_MP_TABLE
> >>
> > Hmm? Shouldn't GENERATE_ be set by the user.. ?
> >
> >
> The user should never have to worry about that stuff.
> We should not expect the user to manually enable ACPI and PIRQ before he
> has a chance to get a bootable system with coreboot.
>
As long as the user doesn't touch it, GENERATE_ was set by default as long
as the board has HAVE_* set.  What this patch did was make it so that the
user can't build without ACPI tables.  I don't think that is what's wanted.
Now to remove the MP_TABLE, the user would have to edit the Kconfig file.

Thanks,
Myles
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://www.coreboot.org/pipermail/coreboot/attachments/20091218/b3212372/attachment.html>


More information about the coreboot mailing list