[coreboot] [PATCH] flashrom patch easier board_pciid_enables parsing
stepan at coresystems.de
Wed Jan 14 00:55:45 CET 2009
On 14.01.2009 0:33 Uhr, Peter Stuge wrote:
> ron minnich wrote:
>>>> Similarly to flashchips array, this patch intends to make the
>>>> table board_pciid_enables more readable.
>>> For certain versions of readable. What real problem does this solve?
>> 1. Next time someone adds a new struct member, we avoid mistakes of
>> ordering of initializers
>> 2. we avoid mistakes in the first place.
>> The .x = y stuff was added for a (good) reason, I think this is an
>> Acked-by: Ronald G. Minnich <rminnich at gmail.com>
> Sorry, but I really do not like these at all and I would much rather
> see the chip table change back. There seemed to be general agreement
> about that on IRC the other day as well.
coresystems GmbH • Brahmsstr. 16 • D-79104 Freiburg i. Br.
Tel.: +49 761 7668825 • Fax: +49 761 7664613
Email: info at coresystems.de • http://www.coresystems.de/
Registergericht: Amtsgericht Freiburg • HRB 7656
Geschäftsführer: Stefan Reinauer • Ust-IdNr.: DE245674866
More information about the coreboot