[coreboot] r3891 - trunk/coreboot-v2/src/southbridge/amd/rs690

svn at coreboot.org svn at coreboot.org
Fri Jan 23 23:16:13 CET 2009


Author: mjones
Date: 2009-01-23 23:16:13 +0100 (Fri, 23 Jan 2009)
New Revision: 3891

Modified:
   trunk/coreboot-v2/src/southbridge/amd/rs690/rs690_pcie.c
Log:
Fix rs690 bug about GPPSB configuration.
Signed-off-by:  Maggie Li <maggie.li at amd.com>
Reviewed-by:    Zheng Bao <Zheng.bao at amd.com>
Acked-by: Marc Jones <marcj303 at gmail.com>

Modified: trunk/coreboot-v2/src/southbridge/amd/rs690/rs690_pcie.c
===================================================================
--- trunk/coreboot-v2/src/southbridge/amd/rs690/rs690_pcie.c	2009-01-23 05:23:06 UTC (rev 3890)
+++ trunk/coreboot-v2/src/southbridge/amd/rs690/rs690_pcie.c	2009-01-23 22:16:13 UTC (rev 3891)
@@ -133,8 +133,8 @@
 
 	/* sets desired GPPSB configurations, bit4-7 */
 	reg = nbmisc_read_index(nb_dev, 0x67);
-	reg &= 0xff0f;		/* clean */
-	reg |= cfg->gpp_configuration;
+	reg &= 0xffffff0f;		/* clean */
+	reg |= cfg->gpp_configuration << 4;
 	nbmisc_write_index(nb_dev, 0x67, reg);
 
 	/* read bit14 and write back its inverst value */





More information about the coreboot mailing list