[coreboot] [PATCH] some more CONFIG_ prefixes

Myles Watson mylesgw at gmail.com
Mon Jul 20 15:57:39 CEST 2009


> attached patch renames some preprocessor symbols. I have no idea why
> those symbols were left alone before, after this, they're somewhat more
> in line with the rest of the tree.


@@ -18,8 +18,8 @@
 #define MAINBOARD_POWER_OFF 0
 #define MAINBOARD_POWER_ON  1
 
-#ifndef MAINBOARD_POWER_ON_AFTER_FAIL
-#define MAINBOARD_POWER_ON_AFTER_FAIL MAINBOARD_POWER_ON
+#ifndef CONFIG_MAINBOARD_POWER_ON_AFTER_POWER_FAIL
+#define CONFIG_MAINBOARD_POWER_ON_AFTER_POWER_FAIL MAINBOARD_POWER_ON
 #endif

Since they're #ifndef, that means they weren't part of the old config
system, or there is a bug.  Those symbols are always defined, and are tested
based on their values.  Is there a uses statement for them somewhere?

Thanks,
Myles





More information about the coreboot mailing list