[coreboot] [PATCH] flashrom: Only probe for chips with compatible bus protocols

Uwe Hermann uwe at hermann-uwe.de
Mon Jun 1 04:04:50 CEST 2009


On Mon, Jun 01, 2009 at 03:48:40AM +0200, Carl-Daniel Hailfinger wrote:
> New patch. Changes compared to version 2:
> - If a chip is listed as NONSPI, print "Non-SPI".
> - If a chip is listed as UNKNOWN, print "Unknown".
> 
> Signed-off-by: Carl-Daniel Hailfinger <c-d.hailfinger.devel.2006 at gmx.net>

Acked-by: Uwe Hermann <uwe at hermann-uwe.de>

Looks good, and I tested a successful read/write/erase of an LPC chip
on actual hardware.

 
> Index: flashrom-chiptype_avoid_bus_mismatch/flashrom.c
> ===================================================================
> --- flashrom-chiptype_avoid_bus_mismatch/flashrom.c	(Revision 559)
> +++ flashrom-chiptype_avoid_bus_mismatch/flashrom.c	(Arbeitskopie)
> @@ -174,10 +174,56 @@
>  	return 0;
>  }
>  
> +char *strcat_realloc(char *dest, char *src)

src can be 'const char *src' I think.


Uwe.
-- 
http://www.hermann-uwe.de  | http://www.holsham-traders.de
http://www.crazy-hacks.org | http://www.unmaintained-free-software.org




More information about the coreboot mailing list