[coreboot] [patch] fix intel 82810 onboard VGA and SDRAM functions
joe at settoplinux.org
Fri Jun 5 05:20:15 CEST 2009
On Fri, 5 Jun 2009 02:27:09 +0200, Uwe Hermann <uwe at hermann-uwe.de> wrote:
> On Fri, May 22, 2009 at 03:54:43AM +0300, Elia Yehuda wrote:
>> > On Sun, 10 May 2009 15:21:52 +0300, Elia Yehuda <z4ziggy at gmail.com>
>> > > This patch enables the onboard VGA found on 82810 boards and fixes
>> > > memory procedures to support different kinds of DIMMs. also, support
>> > > 82810e board had been added. The only drawback from this patch is
>> > > HAVE_HIGH_TABLES being disabled since it disables (for unknown
>> > > the onboard VGA.
>> > >
>> > > Signed-off-by: Elia Yehuda <z4ziggy at gmail.com>
>> > Elia, any progress on the high tables stuff yet? It would be real
> shame to
>> > see this great code goto the way side. Maybe you could split the patch
>> > two and we can get all the non high tables stuff commited to svn?
>> im still waiting for Uwe to try the patch - he has some issues with his
>> hardware so we
>> need to have patience.
> Yeah, sorry for the long delay. I had hardware issues, which I fixed by
> replacing some dead capacitors on my i810 board.
> I have successfully tested the (slightly modified for cosmetics) BUFF_SC
> parts of the patch, which works fine and is thus committed as r4338
>> If this won't work out, then i'll do my best and
>> trace the high-tables
>> issue myself and update the list as for my findings.
>> as for splitting the patch - can be done, but i suggest we wait a bit
>> give Uwe a chance
> In general I recommend to split patches into independent functional
> units indeed, that makes testing and reviewing a lot easier.
> Haven't had much luck with the HIGH_TABLES stuff yet, need to look into
> it some more, will post the remainders of the patch (without the
> now-committed BUFF_SC parts) later and/or check what's going on with
Sweet thanks Uwe :-)
More information about the coreboot