[coreboot] [PATCH] Use die() properly

Carl-Daniel Hailfinger c-d.hailfinger.devel.2006 at gmx.net
Fri Jun 5 15:28:34 CEST 2009


On 05.06.2009 15:21, Uwe Hermann wrote:
> On Fri, Jun 05, 2009 at 01:19:34PM +0200, Carl-Daniel Hailfinger wrote:
>   
>>  		printk_alert("%s Cannot find smbus bus operations", dev_path(dev));
>>  		die("");
>>     
>
> Can we also make die() accept variable argument numbers so we can do this?
>   

I wanted to do that, but AFAICS it fails for early ROMCC compiled code.

>   die("%s Cannot find smbus bus operations", dev_path(dev));
>
> Or does this cause issues when die() is called very early (pre-RAM) or so?
>   

It sure would be desirable.
Once the CBFS conversion goes as planned and Ron's conversion to v3
startup is done, converting boards to CAR should be doable and give us
(among others) die() with parameters.

Regards,
Carl-Daniel

-- 
http://www.hailfinger.org/





More information about the coreboot mailing list