[coreboot] write/verify bug

[Ward Vandewege]

On Fri, Jun 12, 2009 at 12:52:41PM +0200, Carl-Daniel Hailfinger wrote:
> > flashrom -e -- erase
> > flashrom -r -- read
> > flashrom -w -- write
> > flashrom -v -- verify
> >
> > flashrom -any combination -- mistake
> 
> I really like this. May I humbly request we auto-verify both erase and
> write operations to give the user feedback if an operation failed. Right
> now it can happen that erase or write fails and the user it not told
> about it.

Yes, please, that sounds sensible to me. Auto-verify is great. Also for read,
or does that not make much sense?

> > Otherwise, no matter how you set this up, you're going to violate
> > somebody's principle of least surprise. This thread already shows how.
> >   
> 
> True. Except for speed reasons, there shouldn't be any opposition to
> auto-verify. (For disabling auto-verify, a separate option could be added.)

Sounds perfect with that extra option to disable auto-verify.

> Basically, we'd keep --verify as standalone operation, but it would be
> invoked automatically for erase and write.

Yes.

> Thoughts? I have a patch pending for this. I'll clean it up and send.

Please!

Thanks,
Ward.

-- 
Ward Vandewege <ward at fsf.org>
Free Software Foundation - Senior Systems Administrator