[coreboot] [PATCH]i82830 custom vga driver

Stefan Reinauer stepan at coresystems.de
Fri May 1 11:22:24 CEST 2009


On 01.05.2009 6:06 Uhr, Myles Watson wrote:
> On Thu, Apr 30, 2009 at 9:52 PM, Joseph Smith <joe at settoplinux.org> wrote:
>   
>> This patch allows a custom vga driver that will give the flexibility to run
>> code after vga is initialized for tv-out. It is one of many patches to
>> come, including code to manipulate the graphics mmio registers, enable the
>> graphics i2c data lines, and tv encoder drivers.
>>     
>
> Should it be conditionally included via a config option?  Are there
> other boards with the same chipset that won't want to use this TV-out
> initialization?
>   
Please, no more CONFIG flags.

- If it's a property of the board / northbridge, it should be a variable
in the chip's config structure

- there's no real code in that function, so there's not much sense to
make anything conditional yet.

Stefan

-- 
coresystems GmbH • Brahmsstr. 16 • D-79104 Freiburg i. Br.
      Tel.: +49 761 7668825 • Fax: +49 761 7664613
Email: info at coresystems.dehttp://www.coresystems.de/
Registergericht: Amtsgericht Freiburg • HRB 7656
Geschäftsführer: Stefan Reinauer • Ust-IdNr.: DE245674866

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://www.coreboot.org/pipermail/coreboot/attachments/20090501/d41a4aeb/attachment.html>


More information about the coreboot mailing list