[coreboot] [PATCH]Fix ACPI in HIGH-and-LOW tables configuration

Myles Watson mylesgw at gmail.com
Wed May 13 14:35:32 CEST 2009


On Wed, May 13, 2009 at 6:28 AM, Patrick Georgi <patrick at georgi-clan.de> wrote:
> Am 13.05.2009 14:20, schrieb Myles Watson:
>>
>> Can you move the declaration of high_rsdp too?  One less #if.
>
> high_table_end changes in the meantime. I could store it somewhere else, but
> I'm not sure if that's a cleaner solution

Yep.

>> I don't see how this changes the functionality.  Which variable are you
>> worried about?  Sorry if I'm being blind.
>
> -       unsigned long rsdt_location=(unsigned
> long*)(((acpi_rsdp_t*)high_rsdp)->rsdt_address);
>
> high_rsdp->rsdt_address is filled in by write_acpi_table().

Acked-by: Myles Watson <mylesgw at gmail.com>

Thanks,
Myles




More information about the coreboot mailing list