[coreboot] [cbfstool] [PATCH] fix segfault when adding file that won't fit

Ward Vandewege ward at gnu.org
Wed May 13 22:11:30 CEST 2009


On Wed, May 13, 2009 at 02:06:30PM -0600, Myles Watson wrote:
> This patch fixes a segfault when a file too large to fit is added to a rom
> image.
> 
> Signed-off-by: Ward Vandewege <ward at gnu.org>
> 
> Index: fs.c
> ===================================================================
> --- fs.c	(revision 4281)
> +++ fs.c	(working copy)
> @@ -99,7 +99,7 @@
>  {
>  	/* walk the rom and find an empty file with a base > base, and a
> large enough size */
>  	unsigned int offset = ntohl(rom->header->offset);
> -	unsigned int ret = -1;
> +	int ret = -1;
> 
> Good catch.
> 
> Acked-by: Myles Watson <mylesgw at gmail.com>

r4283

Thanks,
Ward.

-- 
Ward Vandewege <ward at fsf.org>
Free Software Foundation - Senior Systems Administrator




More information about the coreboot mailing list