[coreboot] [PATCH] flashrom: Make packagers happy

[Carl-Daniel Hailfinger]

On 29.05.2009 16:12, Peter Stuge wrote:
> Carl-Daniel Hailfinger wrote:
>   
>> I can't remember where flashrom ends up.
>>     
>
> I only find v2 and v3 at http://qa.coreboot.org/snapshots/
>   

I think it was part of a trac page. Anyway, a canonical download
location for flashrom is the way to go.


>> I agree that we need to have a page which points to all snapshots.
>>     
>
> Either on the Download page or on each relevant page. In the Flashrom
> case I think it belongs on the Flashrom page.
>   

Agreed.


>> +# Note to packagers: Any tree exported with "make export" or "make tarball"
>> +# will not require subversion.
>>     
>
> Do we need to say so? It think it is really intuitive that a snapshot
> doesn't require svn.
>   

Considering that packagers patch it out at the moment, I'd like to give
them a hint that make export solves the issue.


>> +export:
>> +	@svn export . flashrom-$(VERSION)
>> +	@sed "s/^SVNVERSION.*/SVNVERSION := $(SVNVERSION)/" Makefile >flashrom-$(VERSION)/Makefile
>> +	@echo Exported flashrom repository contents to flashrom-$(VERSION)/
>>     
>
> Well, it exports the working copy, which might have changes. At least
> add -r to the export. It would be very nice to make the rule also
> apply to releases while at it. Right now it adds the rev back in. I
> don't know how to do that very neatly however. :\
>   

Originally, I wanted to have releases without svn revision. However, I
noticed that distributions tend to package newer snapshots under the
name of the release.
Having the revision in releases+snapshots also allows us to quickly go
to the correct revision without having to look it up or switch branches.
Plus, it kills two unnecessary commits per release.


>> +tarball: export
>> +	@tar cfz flashrom-$(VERSION).tar.gz flashrom-$(VERSION)/
>> +	@echo Created tarball of repository contents at flashrom-$(VERSION).tar.gz
>>     
>
> Again, it's not really the repo contents. With -r it is, then maybe
> just say Created $filename because tar and the rev are part of the
> filename?
>   

OK. Should we use the (unmodified) repo contents or the directory contents?


>>  .PHONY: all clean distclean dep pciutils
>>     
>
> I think export and tarball should be added to .PHONY.
>   

Will do.


>> +Packaging
>> +---------
>>     
>
> Really in the README? Do we have INSTALL? Maybe it's time?
>   

Good point. I'd postpone splitting to another patch, though.

I'll wait for your answer on the points above, then post a new patch. OK
for you?

Regards,
Carl-Daniel

-- 
http://www.hailfinger.org/