[coreboot] Coreboot bug?

Myles Watson mylesgw at gmail.com
Wed Nov 11 23:51:47 CET 2009


On Wed, Nov 11, 2009 at 3:50 PM, Myles Watson <mylesgw at gmail.com> wrote:
> On Wed, Nov 11, 2009 at 3:49 PM, ron minnich <rminnich at gmail.com> wrote:
>> On Wed, Nov 11, 2009 at 2:39 PM, Myles Watson <mylesgw at gmail.com> wrote:
>>
>>> -               memcpy(rec_dest,  rec_src, rec_src->size);
>>> +               memcpy(rec_dest,  &option_table, sizeof(option_table));
>>
>> how can this be right? rec_src->size is 1160, and sizeof(option_table) is 8?
> sizeof(&option_table) is 8, right?
No.
sizeof(&option_table) is 4
sizeof(rec_dest) is 8.

option_table is a large character array

unsigned char option_table[] = {
       0xc8,0x00,0x00,0x00,0x88,0x04,0x00,0x00,0x0c,0x00,

Thanks,
Myles




More information about the coreboot mailing list