[coreboot] [PATCHES]: coreboot-v2 on win32 / mingw

Patrick Georgi patrick at georgi-clan.de
Sat Nov 21 20:55:29 CET 2009


Am 21.11.2009 20:21, schrieb Peter Stuge:
> It's common to guard x in each use with () I guess in order to avoid
> ordering issues if x isn't a simple number.
>    
Fixed

> Maybe name UNLINK() something else to show that it's not always being
> done?
>    
UNLINK_IF_NECESSARY, then.

>> +	awk '/^#define ([^"])* ([^"])*$$/ {gsub("\\r","",$$3); print $$2 " = " $$3 ";";}' $<  >  $@
>>      
> This assumes that the macro expansion will never contain whitespace -
> is that true? If not, I suggest:
>    
It worked so far, and that part of the line didn't change. I'll test a 
bit more.

>  Acked-by: Peter Stuge<peter at stuge.se>
Thanks, r4952


Patrick





More information about the coreboot mailing list