[coreboot] [PATCH]Unify .id section offsets
c-d.hailfinger.devel.2006 at gmx.net
Fri Nov 27 18:42:07 CET 2009
On 27.11.2009 17:59, Patrick Georgi wrote:
> Am 27.11.2009 17:40, schrieb ron minnich:
>> I'm going to ack this but: could we not get rid of the id section and
>> make it a CBFS file instead?
>> I think the use of sections should be limited to only those cases
>> where hardware leaves us no choice.
> I need that special case out of the way. If someone builds a better
> way (and cbfs is indeed a good idea), I'm all for it.
> I think that any functional change requires changes in flashrom, so I
> hesitated to just change behaviour.
Please no CBFS/LAR parser in flashrom! You could place the ID in its own
CBFS member and still have some pointer (in the master header or
whatever) point to the ID. The only thing this needs is a final fixup
state for cbfstool. With some careful coding, the new scheme will even
be compatible with the old one.
However, if parsing CBFS in flashrom becomes necessary, I first want a
sure way to identify coreboot images (rather than the current
trial-and-error method). Right now the flashrom code has some pending
unreviewed changes in that area, so it is unlikely that any CBFS related
stuff ends up in flashrom 0.9.2. To be fair to v3 users, we'd have to
merge LAR parsing as well if we merge CBFS parsing.
Developer quote of the month:
"We are juggling too many chainsaws and flaming arrows and tigers."
More information about the coreboot