[coreboot] [PATCH]Remove non-CBFS

[Patrick Georgi]

Am Mittwoch, den 30.09.2009, 15:41 -0600 schrieb Myles Watson:
> >Index: src/devices/pci_rom.c
> >===================================================================
> >--- src/devices/pci_rom.c	(Revision 4696)
> >+++ src/devices/pci_rom.c	(Arbeitskopie)
> >@@ -35,17 +35,15 @@
> > 	struct rom_header *rom_header;
> > 	struct pci_data *rom_data;
> 
> > 	if (dev->on_mainboard) {
> > 		/* this is here as a legacy path. We hope it goes away soon.
> >Users should not have to 
> 
> The legacy path is the non-CBFS path and should disappear
The comment is wrong. dev->on_mainboard is set by the CBFS loader a
couple of lines above. This distinction is mostly "ROM in flash" vs.
"ROM in option ROM" now.

Users won't have to calculate addresses with CBFS, so it's fine.
I'll kill the comment in the commit, thanks for the pointer!


> >-#if CONFIG_CBFS == 1
> >-# if CONFIG_USE_FALLBACK_IMAGE == 1
> >+#if CONFIG_USE_FALLBACK_IMAGE == 1
> > str_coreboot_ram_name:	.string "fallback/coreboot_ram"
> >-# else
> >+#else
> > str_coreboot_ram_name:	.string "normal/coreboot_ram"
> >-# endif
> > #endif
> 
> Since normal and failover aren't supported with CBFS, can they disappear
> too?
They are supported with CBFS on newconfig. It's Kconfig that doesn't
support these, but newconfig will have to stay for a while, and so do
these.


Patrick