[coreboot] [v2] r4746 - trunk/coreboot-v2/src/mainboard

[svn at coreboot.org]

Author: rminnich
Date: 2009-10-08 19:10:20 +0200 (Thu, 08 Oct 2009)
New Revision: 4746

Modified:
   trunk/coreboot-v2/src/mainboard/Makefile.romccboard.inc
Log:

This dialogue on email was useful and hence included. 


failover.inc MUST come after enable_sse or your CPU will hang.

> Can you say why?

yes. if you compile failover.c with romcc options that include sse, 
then you'll see code like this in failover.inc:
mov eax, %xmm0

This will hang if you have not first enabled sse. 
Verified yesterday on the dell s1850. 

>
> Does it hang in the SSE code or in the failover code?

It will hang in failover code, if that code was compiled with sse enabled
AND if the sse registers are used. 

>
> Does this mean that failover requires SSE in order to work?

It may or it may not. 
But if you compile it with romcc options that include sse, 
and it uses sse without sse being enabled, it will hang. 
This is a particularly nasty bug in that the failover code is not 
guaranteed to compile in a way that sse is used, even if sse is 
enabled; hence, this could be very hard to catch. 
I'm lucky this bug appeared as soon as it did.

Signed-off-by: Ronald G. Minnich <rminnich at gmail.com>
Acked-by: Peter Stuge <peter at stuge.se>


Modified: trunk/coreboot-v2/src/mainboard/Makefile.romccboard.inc
===================================================================
--- trunk/coreboot-v2/src/mainboard/Makefile.romccboard.inc	2009-10-08 16:06:09 UTC (rev 4745)
+++ trunk/coreboot-v2/src/mainboard/Makefile.romccboard.inc	2009-10-08 17:10:20 UTC (rev 4746)
@@ -24,18 +24,16 @@
 crt0-y += ../../../../src/cpu/x86/16bit/reset16.inc
 crt0-y += ../../../../src/arch/i386/lib/cpu_reset.inc
 crt0-y += ../../../../src/arch/i386/lib/id.inc
-crt0-y += failover.inc
 crt0-y += ../../../../src/cpu/x86/fpu/enable_fpu.inc
 
-ifeq ($(CONFIG_CPU_AMD_GX1),y)
-crt0-y += ../../../../src/cpu/amd/model_gx1/cpu_setup.inc
-crt0-y += ../../../../src/cpu/amd/model_gx1/gx_setup.inc
+crt0-$(CONFIG_CPU_AMD_GX1) += ../../../../src/cpu/amd/model_gx1/cpu_setup.inc
+crt0-$(CONFIG_CPU_AMD_GX1) += ../../../../src/cpu/amd/model_gx1/gx_setup.inc
+crt0-$(CONFIG_MMX) += ../../../../src/cpu/x86/mmx/enable_mmx.inc
+crt0-$(CONFIG_SSE) += ../../../../src/cpu/x86/sse/enable_sse.inc
+crt0-y += failover.inc
 crt0-y += auto.inc
-else
-crt0-y += ../../../../src/cpu/x86/mmx/enable_mmx.inc
-crt0-y += auto.inc
-crt0-y += ../../../../src/cpu/x86/mmx/disable_mmx.inc
-endif
+crt0-$(CONFIG_SSE) += ../../../../src/cpu/x86/sse/disable_sse.inc
+crt0-$(CONFIG_MMX) += ../../../../src/cpu/x86/mmx/disable_mmx.inc
 
 ldscript-y += ../../../../src/arch/i386/init/ldscript_fallback_cbfs.lb
 ldscript-y += ../../../../src/cpu/x86/16bit/entry16.lds