[coreboot] [PATCH] Drop MAX_PCI_BUSES

[Uwe Hermann]

On Fri, Oct 16, 2009 at 05:04:52PM +0200, Peter Stuge wrote:
> ron minnich wrote:
> > I doubt we need it any more.
> 
> Thanks for the explanations, Myles and Ron! See patch.
> 
> 
> //Peter

> Drop CONFIG_MAX_PCI_BUSES
> 
> It was added by rsmith in r2273 on 20060424, when pci_locate_device() in
> src/arch/i386/include/arch/romcc_io.h in fact scanned all busses:
> 
> - for(; dev <= PCI_DEV(255, 31, 7); dev += PCI_DEV(0,0,1)) {
> + for(; dev <= PCI_DEV(CONFIG_MAX_PCI_BUSES, 31, 7); dev += PCI_DEV(0,0,1)) {
> 
> Today this looks like:
> 
>   for(; dev <= PCI_DEV(255|(((1<<CONFIG_PCI_BUS_SEGN_BITS)-1)<<8), 31, 7); dev += PCI_DEV(0,0,1)) {
> 
> and CONFIG_MAX_PCI_BUSES is never used anywhere.
> 
> Signed-off-by: Peter Stuge <peter at stuge.se>

Looks like you were faster, but here's my patch nonetheless.
It removeѕ some additional useless comments. Also, the change in
src/config/Options.lb is not correct and will likely break the build.


> Index: src/config/Options.lb
> ===================================================================
> --- src/config/Options.lb	(revision 4787)
> +++ src/config/Options.lb	(working copy)
> @@ -562,7 +562,6 @@
>  	export used
>  	comment "System clock frequency in MHz"
>  end
> -define CONFIG_MAX_PCI_BUSES
>  	default 255
>  	export always
>  	comment "Maximum number of PCI buses to search for devices"


Uwe.
-- 
http://www.hermann-uwe.de  | http://www.randomprojects.org
http://www.crazy-hacks.org | http://www.unmaintained-free-software.org
-------------- next part --------------
A non-text attachment was scrubbed...
Name: v2_kconfig_drop_max_pci_buses.patch
Type: text/x-diff
Size: 6900 bytes
Desc: not available
URL: <http://www.coreboot.org/pipermail/coreboot/attachments/20091016/3ff1a845/attachment.bin>