[coreboot] [PATCH] Maximum/default console log level for kconfig

Uwe Hermann uwe at hermann-uwe.de
Fri Oct 16 21:20:12 CEST 2009


On Tue, Oct 13, 2009 at 08:51:30AM -0600, Myles Watson wrote:
> While I was fooling with it, I made Kconfig ensure that
> MAXIMUM_CONSOLE_LOGLEVEL >= DEFAULT_CONSOLE_LOGLEVEL to minimize the
> number of test cases I needed.
> 
> Signed-off-by: Myles Watson <mylesgw at gmail.com>

Untested, but looks good.

Acked-by: Uwe Hermann <uwe at hermann-uwe.de>


> Index: svn/src/console/Kconfig
> ===================================================================
> --- svn.orig/src/console/Kconfig
> +++ svn/src/console/Kconfig
> @@ -141,34 +141,54 @@ choice
>  
>  config DEFAULT_CONSOLE_LOGLEVEL_8
>          bool "8: SPEW"
> +	depends on (MAXIMUM_CONSOLE_LOGLEVEL >= 8)

The indentation in this file looks strange as the items didn't use TABs
so far, feel free to change them all to TABs in this or in an extra
commit.

Having DEFAULT_CONSOLE_LOGLEVEL depend on the MAXIMUM_CONSOLE_LOGLEVEL
is really nice!


Uwe.
-- 
http://www.hermann-uwe.de  | http://www.randomprojects.org
http://www.crazy-hacks.org | http://www.unmaintained-free-software.org




More information about the coreboot mailing list