[coreboot] [PATCH] serialice: Fix a couple of minor typos

Uwe Hermann uwe at hermann-uwe.de
Sun Oct 18 04:56:07 CEST 2009


On Wed, Oct 14, 2009 at 09:07:43AM +0100, Mark Marshall wrote:
> I've been lurking here for some time, but this is my first post /
> patch.   I'm about to start playing with coreboot a bit and was
> thinking about getting serialice working with the ASUS P2B (I'm
> interested in this vintage of hardware at the moment).

I have a patch for P2B-F somewhere, need to test if that works and then
send in. P2B should be very similar.

 
> Correct the type of the parameter 'port' in the function
> pnp_set_logical_device.  This should be a u16.  I'm not aware of this
> causing a problem with any of the current mainboards as there ports
> are all less than 256, but this will cause problems with mainboards
> that have there PNP configuration port at 0x3F0.

Yep.

 
> Signed off by:  Mark Marshall

The patch was committed as r28, thanks!


Uwe.
-- 
http://www.hermann-uwe.de  | http://www.randomprojects.org
http://www.crazy-hacks.org | http://www.unmaintained-free-software.org




More information about the coreboot mailing list