[coreboot] [PATCH] more Kconfig selects

[Uwe Hermann]

On Tue, Oct 20, 2009 at 09:19:37AM -0600, Myles Watson wrote:
> I compared the config variables that we select with the list that we define.
> 
> I removed CONFIG_CPU_AMD_FAM10 & CONFIG_CPU_AMDK8 from mainboards.  They
> should be selected in sockets, and they aren't used yet.
> 
> I added a couple of variables to src/Kconfig for lack of a better place so
> that their selects would work.
> I added select statements according to newconfig for some variables that
> were defined but never selected in mainboard configs.
> 
> Signed-off-by: Myles Watson <mylesgw at gmail.com>

Acked-by: Uwe Hermann <uwe at hermann-uwe.de>

But see below for material for discussions and/or a followup patch.


> Index: svn/src/mainboard/asus/m2v-mx_se/Kconfig
> ===================================================================
> --- svn.orig/src/mainboard/asus/m2v-mx_se/Kconfig
> +++ svn/src/mainboard/asus/m2v-mx_se/Kconfig
> @@ -21,7 +21,6 @@
>  config BOARD_ASUS_M2V_MX_SE
>  	bool "M2V-MX SE"
>  	select ARCH_X86
> -	select CPU_AMD_K8
>  	select CPU_AMD_SOCKET_AM2
>  	select NORTHBRIDGE_AMD_AMDK8
>  	select NORTHBRIDGE_AMD_AMDK8_ROOT_COMPLEX
> @@ -35,6 +34,7 @@ config BOARD_ASUS_M2V_MX_SE
>  	select HAVE_OPTION_TABLE
>  	select HAVE_ACPI_TABLES
>  	select BOARD_ROMSIZE_KB_512
> +	select VGA

All CONFIG_VGA occurences:

config/Options.lb:define CONFIG_VGA

OK


include/pc80/vga.h:#if (CONFIG_VGA == 1)
include/pc80/vga.h:#endif /* (CONFIG_VGA == 1) */

These should probably be changed to
  #if CONFIG_VGA


mainboard/intel/eagleheights/Options.lb:uses CONFIG_VGA
mainboard/intel/eagleheights/Options.lb:#default CONFIG_VGA=0

Unused here, so can be dropped from Options.lb?


mainboard/asus/m2v-mx_se/Options.lb:uses CONFIG_VGA
mainboard/asus/m2v-mx_se/Options.lb:default CONFIG_VGA = 1

OK.


pc80/vga/Makefile.inc:obj-$(CONFIG_VGA) += vga.o
pc80/vga/Config.lb:uses CONFIG_VGA
pc80/vga/Config.lb:if CONFIG_VGA

OK.


southbridge/via/k8t890/k8m890_chrome.c:#if CONFIG_VGA == 1
southbridge/via/k8t890/k8m890_chrome.c:#if CONFIG_VGA == 1

These should probably be changed to
  #if CONFIG_VGA


> Index: svn/src/mainboard/emulation/qemu-x86/Kconfig
> ===================================================================
> --- svn.orig/src/mainboard/emulation/qemu-x86/Kconfig
> +++ svn/src/mainboard/emulation/qemu-x86/Kconfig
> @@ -1,7 +1,6 @@
>  config BOARD_EMULATION_QEMU_X86
>  	bool "QEMU x86"
>  	select ARCH_X86
> -	select CPU_I586
>  	select SOUTHBRIDGE_INTEL_I82371EB
>  	select CPU_EMULATION_QEMU_X86
>  	select HAVE_PIRQ_TABLE

Yep, I think this is a remainder from v3.


> Index: svn/src/mainboard/intel/jarrell/Kconfig
> ===================================================================
> --- svn.orig/src/mainboard/intel/jarrell/Kconfig
> +++ svn/src/mainboard/intel/jarrell/Kconfig
> @@ -9,6 +9,7 @@ config BOARD_INTEL_JARRELL
>  	select HAVE_PIRQ_TABLE
>  	select HAVE_MP_TABLE
>  	select UDELAY_TSC
> +	select USE_WATCHDOG_ON_BOOT
>  	select ATI_RAGE_XL
>  	select BOARD_ROMSIZE_KB_2048

There are the following occurences:

config/Options.lb:define CONFIG_USE_WATCHDOG_ON_BOOT

  The comment says "Use the watchdog on booting" which is not really
  descriptive. What does "use" mean here? Disable it? We should fix
  the comment I guess (and the resp. Kconfig help text).

include/part/watchdog.h:#if CONFIG_USE_WATCHDOG_ON_BOOT == 1
Kconfig:config USE_WATCHDOG_ON_BOOT

mainboard/kontron/986lcd-m/Options.lb:uses CONFIG_USE_WATCHDOG_ON_BOOT
mainboard/kontron/986lcd-m/Options.lb:default CONFIG_USE_WATCHDOG_ON_BOOT=0
mainboard/intel/eagleheights/Options.lb:uses CONFIG_USE_WATCHDOG_ON_BOOT
mainboard/intel/eagleheights/Options.lb:default CONFIG_USE_WATCHDOG_ON_BOOT=0

These two can drop the variable completely I assume, as they don't use it?


mainboard/intel/jarrell/Options.lb:uses CONFIG_USE_WATCHDOG_ON_BOOT
mainboard/intel/jarrell/Options.lb:default CONFIG_USE_WATCHDOG_ON_BOOT=1

This is fixed by your change above.


mainboard/lippert/spacerunner-lx/cache_as_ram_auto.c:#if !CONFIG_USE_WATCHDOG_ON_BOOT
mainboard/lippert/roadrunner-lx/cache_as_ram_auto.c:#if !CONFIG_USE_WATCHDOG_ON_BOOT

Not sure about these two. They use the variable but never add a "uses"
line in Option.lb?


Uwe.
-- 
http://www.hermann-uwe.de  | http://www.randomprojects.org
http://www.crazy-hacks.org | http://www.unmaintained-free-software.org