[coreboot] [PATCH] rework keyboard driver

Myles Watson mylesgw at gmail.com
Sat Oct 24 21:37:39 CEST 2009


> >            if ((port0 == 0x60) && (port1 == 0x64)) {
> >
> > Same thing here, right?
> I like the idea, but ... Shouldn't we drop that whole function instead?
> It's a runtime check for compile time settings, which generally sounds
> like a bad idea.
Yes.  You're right.

Thanks,
Myles 






More information about the coreboot mailing list