[coreboot] [PATCH] resource allocator hole handling (simple and old)

Myles Watson mylesgw at gmail.com
Sun Oct 25 05:01:36 CET 2009


Index: src/devices/device.c
===================================================================
--- src/devices/device.c	(revision 4842)
+++ src/devices/device.c	(working copy)
@@ -576,7 +576,7 @@
 			continue;
 
 		/* Is it already outside the limits? */
-		if (res->size && (((res->base + res->size -1) < lim->base)
||
+		if (!res->size || (((res->base + res->size -1) < lim->base)
||
 				  (res->base > lim->limit)))
 			continue;

I think fixed resources of size 0 are broken.  I'd rather fix the targets.
It's hard for the allocator to avoid size 0 resources.

Thanks,
Myles





More information about the coreboot mailing list