[coreboot] [PATCH] kconfig: Allow per-board VGA BIOS file name and PCI ID defaults

[Peter Stuge]

Uwe Hermann wrote:
> Allow per-board VGA BIOS file name and PCI ID defaults.

NAK actually. For one, please talk about the relationship between the
proposed VGA_BIOS_{FILE,ID} and the previous
FALLBACK_VGA_BIOS_{FILE,ID} ?

Also I assume there will at one point be NORMAL_*, right?


If the purpose is strictly to provide a useful default for each board
then I think VGA_BIOS_FILE should be dropped, because the VGA BIOS
only really has a well known filename for QEMU.


The PCI ID isn't really a board property. Most of the time the it is
a function of the northbridge, but sometimes it IS set by the board.

Can Kconfig deal with a single value being set in more than one
place? How is precedence determined? Even if it can, that method
feels kind of ugly.

Can a single value get it's default from one of several other values,
depending on settings, with a particular precedence specified?

NB must be able to set VGA_PCI_ID. Board must also be able to set
VGA_PCI_ID. If neither have set it, there can be no VGA BIOS and
the option should not even be visible in the menu. If only NB has
set an ID, use that ID. If only board, or both NB and board have set
ID, then use the board ID.


//Peter