[coreboot] [PATCH] Make COM port selection and BAUD rate a "choice"

[Uwe Hermann]

On Sat, Oct 17, 2009 at 12:28:40AM +0200, Peter Stuge wrote:
> > Make COM port selection and BAUD rate a "choice" for better usability.
> 
> Must they be called COM ports? And how come BAUD is all caps?

Baud is now fixed. I'd like to keep COM1 etc. visible in menuconfig as
that is what most users will recognize, and also what is printed on
silkscreen on many board PCBs. I added the I/O port in addition, though.


> > +choice
> > +	prompt "COM port"
> 
> "Serial port" ?

Done.


> >  config TTYS0_BASE
> 
> And here it's called TTYS0. This is a little too much variation.

That's a legacy name, not changed in my patch. I agree we should
probably change it to SERIAL_PORT_BASE or something like that.
(there's no TTYS1_BASE in the whole repo btw.)

 
> > -	hex "I/O base for the serial port"
> > +	hex
> >  	depends on CONSOLE_SERIAL8250
> > -	default 0x3f8
> > +	default 0x3f8 if CONSOLE_SERIAL_COM1
> > +	default 0x2f8 if CONSOLE_SERIAL_COM2
> > +	default 0x3e8 if CONSOLE_SERIAL_COM3
> > +	default 0x2e8 if CONSOLE_SERIAL_COM4
> 
> These I/O ports <-> serial ports aren't neccessarily true. Maybe
> have the I/O visible in the options?

Done.


Thanks, Uwe.
-- 
http://www.hermann-uwe.de  | http://www.randomprojects.org
http://www.crazy-hacks.org | http://www.unmaintained-free-software.org