[coreboot] [PATCH] Add prototypes for wrapped libgcc calls

[Stefan Reinauer]

Myles Watson wrote:
>
>
> On Thu, Oct 29, 2009 at 2:38 AM, Stefan Reinauer
> <stepan at coresystems.de <mailto:stepan at coresystems.de>> wrote:
>
>     Myles Watson wrote:
>     > Signed-off-by: Myles Watson <mylesgw at gmail.com
>     <mailto:mylesgw at gmail.com> <mailto:mylesgw at gmail.com
>     <mailto:mylesgw at gmail.com>>>
>     >
>     > Thanks,
>     > Myles
>     I wouldn't move those, ... they're never ever going to be called by
>     anyone. (explicitly)
>
> How about this, then.  Either way silences these warnings:
>
> src/lib/gcc.c:30: warning: no previous prototype for '__wrap___divdi3'
> src/lib/gcc.c:31: warning: no previous prototype for '__wrap___udivdi3'
> src/lib/gcc.c:32: warning: no previous prototype for '__wrap___moddi3'
> src/lib/gcc.c:33: warning: no previous prototype for '__wrap___umoddi3'
>
Ah! Ok, you're of course right.

> Signed-off-by: Myles Watson <mylesgw at gmail.com <mailto:mylesgw at gmail.com>>
As opposed to our previous discussion, I think in this case your second
patch is nicer in this case, as these functions must never be called
directly but only through our gcc workaround wrapper.

Acked-by: Stefan Reinauer <stepan at coresystems.de>

Stefan


-- 
coresystems GmbH • Brahmsstr. 16 • D-79104 Freiburg i. Br.
      Tel.: +49 761 7668825 • Fax: +49 761 7664613
Email: info at coresystems.de  • http://www.coresystems.de/
Registergericht: Amtsgericht Freiburg • HRB 7656
Geschäftsführer: Stefan Reinauer • Ust-IdNr.: DE245674866