[coreboot] [PATCH] WPCD376I Super I/O support

[Uwe Hermann]

Hi,

On Thu, Oct 29, 2009 at 11:23:14AM +0000, Sean Young wrote:
> On the Intel DG33TL motherboard, the Super I/O is an WPCD376I. Output:
> 
> Signed-off-by: Sean Young <sean at mess.org>
 
Thanks a lot for the output and for the patch! I'll commit the code
soon, just two questions. The dump will be linked to from the wiki, so
we have a reference for later usage.


> @@ -532,17 +572,28 @@
>  		rev = INB(port + 1);
>  	}
>  
> -	if (superio_unknown(reg_table, id)) {
> +	/*
> +	 * NSC PC8374L has id 0xf1, rev 0b000x xxxx according to datasheet
> +	 * Winbond WPCD376I has id 0xf1, rev 0b100x xxxx according to datasheet

Why is the code for this Winbond Super I/O in the nsc.c file? I assume
the WPCD376I doesn't need any special enter/exit procedures? But even if
that's the case, shouldn't the code still work fine in the winbond.c file?


> @@ -512,6 +551,7 @@
>  void probe_idregs_nsc(uint16_t port)
>  {
>  	uint8_t id, rev;
> +	int16_t magic;

This can be uint16_t right? Or is there some reason to make it signed
explicitly?

  
Thanks, Uwe.
-- 
http://www.hermann-uwe.de  | http://www.randomprojects.org
http://www.crazy-hacks.org | http://www.unmaintained-free-software.org