[coreboot] [PATCH] kconfig: Allow per-board VGA BIOS file name and PCI ID defaults

[Peter Stuge]

Uwe Hermann wrote:
> > then I think VGA_BIOS_FILE should be dropped, because the VGA BIOS
> > only really has a well known filename for QEMU.
> 
> No, not really. For most users there is a useful per-board default
> file name, namely the one that you get when you do
> 
>   awardeco bios.bin -xa
..
> the file name for the VGA blob as well as the PCI ID defaults will
> already be correct for his or her board, which I find is very
> user-friendly.

Agree!


> > Can Kconfig deal with a single value being set in more than one
> > place?
> 
> Yes (except for "choice" fields, but a workaround with additional
> variables can be done for those too).
> 
> 
> > How is precedence determined? Even if it can, that method
> > feels kind of ugly.
> 
> Why is that ugly?

Because it is not immediately obvious (to us, right now) what the
precedence is.


> We have variables that have sane defaults and can be overridden
> per-chipset or per-board (or by the user in menuconfig if needed).
> It makes perfect sense, IMHO.

Except it's not quite clear how it works.. That doesn't make sense.


> So mainboard values are included first, then northbridge ones. Setting a
> default PCI ID in i945, and another one in Kontron 986LCD-M/mITX worked
> fine in a quick test, i.e. the per-board one overrides the northbridge
> one. This would mean the first definition is used, later ones don't
> override (which sounds a bit strange, but maybe I missed something, it
> was just a quick test).

It could well be that this is how it works, but we have to know if it
is a rather firm design property of confauto, or if it's just a
coincidence.


> Allow per-northbridge and per-board VGA BIOS file name and PCI ID defaults.
> 
> Of course, the user can still override those defaults, if needed.
> 
> Add defaults for the VIA pc2500e and the Kontron 986LCD-M/mITX board.
> 
> Signed-off-by: Uwe Hermann <uwe at hermann-uwe.de>

Acked-by: Peter Stuge <peter at stuge.se>


> +++ src/Kconfig	(Arbeitskopie)
> @@ -379,7 +379,7 @@
>  	  The path and filename of the file to use as VGA BIOS.
>  
>  config FALLBACK_VGA_BIOS_ID
> -	string "VGA BIOS ID"
> +	string "VGA BIOS PCI IDs"
>  	depends on VGA_BIOS
>  	default "1106,3230"
>  	help

Something like "VGA PCI ID" or "VGA PCI device ID" please. The ID is
not a property of the BIOS but of the hardware device that this BIOS
should be attached to.


//Peter