[coreboot] FW: [PATCH]: vga bios was added into image by cbfstool, not by "cat" any more.
stepan at coresystems.de
Fri Oct 30 11:51:55 CET 2009
Myles Watson wrote:
> On Thu, Oct 29, 2009 at 7:28 PM, Peter Stuge <peter at stuge.se
> <mailto:peter at stuge.se>> wrote:
> Stefan Reinauer wrote:
> > CONFIG_PCI_ROM_RUN: Run all option roms
> Now it's run all option roms except VGA.
Ouch... when did that change?
> > CONFIG_VGA_ROM_RUN: Run only VGA option roms
> from src/devices/pci_device.c:
> #if CONFIG_PCI_ROM_RUN == 1 || CONFIG_VGA_ROM_RUN == 1
> void run_bios(struct device *dev, unsigned long addr);
> struct rom_header *rom, *ram;
> if (CONFIG_PCI_ROM_RUN != 1 && /* Only execute VGA ROMs. */
> ((dev->class >> 8) != PCI_CLASS_DISPLAY_VGA))
> if (CONFIG_VGA_ROM_RUN != 1 && /* Only execute non-VGA ROMs. */
> ((dev->class >> 8) == PCI_CLASS_DISPLAY_VGA))
> They got separated so that you can turn them off individually.
> Would anyone cry if these were renamed?
> What would you like to name them?
Then CONFIG_PCI_ROM_RUN should at least be called CONFIG_NONVGA_ROM_RUN
or some such.
coresystems GmbH • Brahmsstr. 16 • D-79104 Freiburg i. Br.
Tel.: +49 761 7668825 • Fax: +49 761 7664613
Email: info at coresystems.de • http://www.coresystems.de/
Registergericht: Amtsgericht Freiburg • HRB 7656
Geschäftsführer: Stefan Reinauer • Ust-IdNr.: DE245674866
More information about the coreboot