[coreboot] Another Kconfig patch

ron minnich rminnich at gmail.com
Tue Sep 22 23:23:16 CEST 2009


On Tue, Sep 22, 2009 at 2:18 PM, Myles Watson <mylesgw at gmail.com> wrote:
> This one lets me boot my s2895 to Linux.  The problem was that the AMD 8131
> southbridge Makefile.inc depended on a typo and never got built.
>
> This patch changes a few things that may be controversial, thanks for
> reviewing.
>
> src/Kconfig: Remove HT-specific options.

Good!

> src/cpu/amd/socket_F/Kconfig: Remove second occurrence of CPU_SOCKET_TYPE.

good.

> src/mainboard/amd/serengeti_cheetah/Kconfig: Add HT_CHAIN_UNITID_BASE here,
> since it is board specific.

makes sense. There seems to be no reasonable default.

> src/mainboard/tyan/s289X/Kconfig: Fix typo and change APIC_ID_OFFSET to
> match old config.

fine.

> src/devices/Kconfig: Change default value of *_PLUGIN_SUPPORT to match old
> config.

fine.

> src/southbridge/amd/amd8131/Makefile.inc: Remove check since it was a typo,
> and the correct variable is checked in the parent directory.

yes, I thought we had killed all these; guess not.

> src/Makefile:Use devicetree.cb instead of Config.lb to generate static.c.
>

oops.

Acked-by: Ronald G. Minnich <rminnich at gmail.com>

Thanks

ron




More information about the coreboot mailing list