[coreboot] [PATCH] more kconfig support

Patrick Georgi patrick at georgi-clan.de
Tue Sep 29 18:31:34 CEST 2009


Am Dienstag, den 29.09.2009, 01:38 +0200 schrieb Peter Stuge:
> > This can be a simple "select HAVE_HARD_RESET" above, but I assume
> > you'll do this kind of changes with a script later?
> 
> PLEASE don't wait until later!
"later" means immediately after all boards are kconfig-aware.
My plan is:
1. get them to build
2. compare old and new build, and make new match old in terms of
   configuration options
3. let other people fix up the remaining issues as they run into them
   with their boards (I don't have all boards around)

I won't fight fixes to existing boards, but I'm not working
board-by-board, that's just too much a hassle.

> New code being developed between first introduction of Kconfig and
> "later" will inherit improper use of Kconfig - I so don't want that.
> 
> If a board is not using Kconfig perfectly I think it's better that it
> does not build!
I can easily add a typo everywhere - that won't help you much.

> Can we avoid this?
The issue is mostly that configuration options are missing, but nothing
"structural".
While there are many things I want to clean up once the old build system
is gone, that will be _later_ steps. I don't want kconfig be killed by
too-many-things-at-once.

> > Can't we eliminate MAINBOARD_OPTIONS?
> 
> Yes, I'd also like to know.
Legacy stuff from early development. Soon to be gone (see other mail).

> > Hm, this is a bit of a hack, maybe make a generic ROMCC_CFLAGS then
> > like this?
> > 
> >   ROMCC_CFLGAGS = -mcpu=p4 -fno-simplify-phi
> 
> Yes please!
Done, called ROMCCFLAGS, with -mcpu=p2 as default







More information about the coreboot mailing list