[coreboot] [v2] r4688 - in trunk/coreboot-v2/src/mainboard: amd/rumba asus/m2v-mx_se intel/jarrell intel/mtarvon intel/truxton intel/xe7501devkit kontron/986lcd-m sunw/ultra40 supermicro/h8dme tyan/s1846 tyan/s2850 tyan/s2875 tyan/s2881 tyan/s289

Myles Watson mylesgw at gmail.com
Tue Sep 29 20:52:04 CEST 2009


On Tue, Sep 29, 2009 at 12:47 PM, Uwe Hermann <uwe at hermann-uwe.de> wrote:
> On Tue, Sep 29, 2009 at 12:23:29PM -0600, Myles Watson wrote:
>> > Modified: trunk/coreboot-v2/src/mainboard/tyan/s2895/Kconfig
>> >  config BOARD_TYAN_S2895
>> > -       bool "Tyan Thunder K8WE S2895"
>> > +       bool "Thunder K8WE (S2895)"
>> >        select PIRQ_TABLE
>> > +       help
>> > +         Tyan Thunder K8WE (S2895) mainboard.
>> Do we need the help here?  I'd rather not have the duplication.
>
> True, it might not be too useful. This may be the right place to
> put board-specific documentation/notes (if any), though.
Sure.  That could be useful.

> Whether
> or not the board name should be mentioned again here is indeed
> debatable. I wouldn't object a patch removing it, but I'd like
> to hear what others think.

A semi-related question I have is what we should do with mainboards
that are re-branded.  I just bought a HP XW9300 board, and it has a
Tyan s2895 BIOS.  I wanted to add that to Kconfig somehow, but I don't
see a very good way.  Suggestions?

Thanks,
Myles




More information about the coreboot mailing list