[coreboot] [PATCH] CAR on Intel P6 Series - Support for model_6bx

Joseph Smith joe at settoplinux.org
Thu Apr 8 23:42:15 CEST 2010




On Thu, 08 Apr 2010 23:37:59 +0200, Stefan Reinauer <stepan at coresystems.de>
wrote:
> On 4/8/10 11:32 PM, Joseph Smith wrote:
>>>> Index: src/cpu/intel/model_6bx/Kconfig
>>>> ===================================================================
>>>> --- src/cpu/intel/model_6bx/Kconfig	(revision 0)
>>>> +++ src/cpu/intel/model_6bx/Kconfig	(revision 0)
>>>> @@ -0,0 +1,3 @@
>>>> +config CPU_INTEL_CORE
>>>> +	bool
>>>> +	select SMP
>>>>
>>>>
>>> Now, this is definitely wrong.
>>>
>>>
>> Oops, I will fix that.
>>
> 
>>>> Index: src/cpu/intel/socket_mfcbga479/Kconfig
>>>> ===================================================================
>>>> --- src/cpu/intel/socket_mfcbga479/Kconfig	(revision 0)
>>>> +++ src/cpu/intel/socket_mfcbga479/Kconfig	(revision 0)
>>>> @@ -0,0 +1,5 @@
>>>> +config CPU_INTEL_SOCKET_MFCBGA479
>>>> +	bool
>>>> +	select CPU_INTEL_MODEL_6BX
>>>>
>>>>
>>> Where is CPU_INTEL_MODEL_6BX defined?
>>>
>>>
>> Not sure what you mean. It is defined by the socket.
>>
> 
> No, it's not. It's used in the socket, but it's never defined anywhere.
> 
hmm, ok I will look into it.

Thanks for your review Stefan.

-- 
Thanks,
Joseph Smith
Set-Top-Linux
www.settoplinux.org





More information about the coreboot mailing list