[coreboot] (no subject)
Uwe Hermann
uwe at hermann-uwe.de
Sun Apr 11 23:21:24 CEST 2010
On Sat, Apr 10, 2010 at 01:33:43PM +0200, Marc Bertens wrote:
> Hi all,
>
> Here is my svn diff for the Nokia IP530, currently its able to run
> coreboot + seabios + sgabios.
Thanks! Please post your Signed-off-by for all patches you send, so we
can commit them.
http://www.coreboot.org/Development_Guidelines#Sign-off_Procedure
> Index: src/mainboard/Kconfig
> ===================================================================
> --- src/mainboard/Kconfig (revision 5355)
> +++ src/mainboard/Kconfig (working copy)
> @@ -96,6 +96,8 @@
> bool "VIA"
> config VENDOR_WINENT
> bool "Win Enterprises"
> +config VENDOR_NOKIA
> + bool "Nokia"
>
> endchoice
>
> @@ -359,6 +361,11 @@
> default "Win Enterprise"
> depends on VENDOR_WINENT
>
> +config MAINBOARD_VENDOR
> + string
> + default "Nokia"
> + depends on VENDOR_NOKIA
> +
> source "src/mainboard/a-trend/Kconfig"
> source "src/mainboard/abit/Kconfig"
> source "src/mainboard/advantech/Kconfig"
> @@ -405,6 +412,7 @@
> source "src/mainboard/tyan/Kconfig"
> source "src/mainboard/via/Kconfig"
> source "src/mainboard/winent/Kconfig"
> +source "src/mainboard/nokia/Kconfig"
Please insert the above entries in alphabetical order respectively
(not as last entries in the lists).
> Index: src/mainboard/nokia/Kconfig
> ===================================================================
> --- src/mainboard/nokia/Kconfig (revision 0)
> +++ src/mainboard/nokia/Kconfig (revision 0)
> @@ -0,0 +1,29 @@
> +##
> +## This file is part of the coreboot project.
> +##
> +## Copyright (C) 2010 Marc Bertens <mbertens at xs4all.nl>
> +##
> +## This program is free software; you can redistribute it and/or modify
> +## it under the terms of the GNU General Public License as published by
> +## the Free Software Foundation; either version 2 of the License, or
> +## (at your option) any later version.
> +##
> +## This program is distributed in the hope that it will be useful,
> +## but WITHOUT ANY WARRANTY; without even the implied warranty of
> +## MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
> +## GNU General Public License for more details.
> +##
> +## You should have received a copy of the GNU General Public License
> +## along with this program; if not, write to the Free Software
> +## Foundation, Inc., 51 Franklin St, Fifth Floor, Boston, MA 02110-1301 USA
> +##
> +
> +choice
> + prompt "Mainboard model"
> + depends on VENDOR_NOKIA
> +##source "src/mainboard/nokia/ip330/Kconfig"
This can be dropped, I assume?
> +source "src/mainboard/nokia/ip530/Kconfig"
> +
> +endchoice
> +
> Index: src/mainboard/nokia/ip530/Kconfig
> ===================================================================
> --- src/mainboard/nokia/ip530/Kconfig (revision 0)
> +++ src/mainboard/nokia/ip530/Kconfig (revision 0)
> @@ -0,0 +1,54 @@
> +##
> +## This file is part of the coreboot project.
> +##
> +## Copyright (C) 2010 Marc Bertens <mbertens at xs4all.nl>
> +##
> +## This program is free software; you can redistribute it and/or modify
> +## it under the terms of the GNU General Public License as published by
> +## the Free Software Foundation; either version 2 of the License, or
> +## (at your option) any later version.
> +##
> +## This program is distributed in the hope that it will be useful,
> +## but WITHOUT ANY WARRANTY; without even the implied warranty of
> +## MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
> +## GNU General Public License for more details.
> +##
> +## You should have received a copy of the GNU General Public License
> +## along with this program; if not, write to the Free Software
> +## Foundation, Inc., 51 Franklin St, Fifth Floor, Boston, MA 02110-1301 USA
> +##
> +
> +config BOARD_NOKIA_IP530
> + bool "IP530"
> + select ARCH_X86
> +## select CPU_INTEL_SLOT_1
> + select CPU_INTEL_SOCKET_PGA370
Is this correct? If it's 440BX chipset it's very likely to be Slot 1.
> + select NORTHBRIDGE_INTEL_I440BX
> + select SOUTHBRIDGE_INTEL_I82371EB
> +## select SUPERIO_WINBOND_W83977TF
> + select SUPERIO_SMSC_SMSCSUPERIO
This also looks strange. Which Super I/O is actually on the board?
> Index: src/mainboard/nokia/ip530/devicetree.cb
> ===================================================================
> --- src/mainboard/nokia/ip530/devicetree.cb (revision 0)
> +++ src/mainboard/nokia/ip530/devicetree.cb (revision 0)
> @@ -0,0 +1,81 @@
Please add the missing license header to this file.
> +chip northbridge/intel/i440bx # Northbridge
> + device apic_cluster 0 on # APIC cluster
> + chip cpu/intel/socket_PGA370 # CPU
Slot 1? See above.
> + device pci 7.2 on end # USB
> + device pci 7.3 on end # ACPI
> + register "ide0_enable" = "1"
> + register "ide1_enable" = "1"
> + register "ide_legacy_enable" = "1"
> + # Enable UDMA/33 for higher speed if your IDE device(s) support it.
> + register "ide0_drive0_udma33_enable" = "0"
> + register "ide0_drive1_udma33_enable" = "0"
> + register "ide1_drive0_udma33_enable" = "0"
> + register "ide1_drive1_udma33_enable" = "0"
I think you can safely set these to "1" too. Actually, we should do this
for all 440BX boards IMHO (per default). If any user should have issues
it's easy enough to set to "0".
> + end
> + device pci 0d.0 on # Ethernet controller: Digital Equipment Corporation DECchip 21142/43 (rev 41)
> + end
> + device pci 0e.0 on # Ethernet controller: Digital Equipment Corporation DECchip 21142/43 (rev 41)
> + end
> + device pci 0f.0 on # CardBus bridge: Texas Instruments PCI1225 (rev 01)
> + end
> + device pci 0f.1 on # CardBus bridge: Texas Instruments PCI1225 (rev 01)
> + end
> + end
> + device pci_domain 1 on # PCI domain 01
> + device pci 00.0 on # PCI bridge: Digital Equipment Corporation DECchip 21150 (rev 06) (prog-if 00 [Normal decode])
> + end
> + end
> + device pci_domain 2 on # PCI domain 02
> + device pci 04.0 on # Ethernet controller: Digital Equipment Corporation DECchip 21142/43 (rev 41)
> + end
> + device pci 04.0 on # Ethernet controller: Digital Equipment Corporation DECchip 21142/43 (rev 41)
> + end
> + end
Not sure if this is needed?
Have you posted "lspci -tvnn" of your board somewhere?
> Index: src/mainboard/nokia/ip530/asus_p2b_irq_tables.c
> ===================================================================
> --- src/mainboard/nokia/ip530/asus_p2b_irq_tables.c (revision 0)
> +++ src/mainboard/nokia/ip530/asus_p2b_irq_tables.c (revision 0)
This must be renamed to irq_tables.c of course. If it does not fully work
yet, we can either commit it if it partially works, or drop it completely
for now.
> Index: src/mainboard/nokia/ip530/irq_tables.c
> ===================================================================
> --- src/mainboard/nokia/ip530/irq_tables.c (revision 0)
> +++ src/mainboard/nokia/ip530/irq_tables.c (revision 0)
Oh, there's an irq_tables.c already, so the above can be dropped I guess.
> @@ -0,0 +1,53 @@
> +const struct irq_routing_table intel_irq_routing_table = {
> + PIRQ_SIGNATURE, /* u32 signature */
> + PIRQ_VERSION, /* u16 version */
> + 32 + 16 * 6, /* Max. number of devices on the bus */
Replace 6 with IRQ_SLOT_COUNT here.
Uwe.
--
http://www.hermann-uwe.de | http://www.randomprojects.org
http://www.crazy-hacks.org | http://www.unmaintained-free-software.org
More information about the coreboot
mailing list