[coreboot] [PATCH] clarify << and -

[Myles Watson]

> Index: src/northbridge/amd/gx2/chipsetinit.c
> ===================================================================
> --- src/northbridge/amd/gx2/chipsetinit.c (revision 5425)
> +++ src/northbridge/amd/gx2/chipsetinit.c (working copy)
> @@ -275,7 +275,7 @@
> if ((msr.lo&0xff) == 0x11)
> return;
>
> - totalmem = sizeram() << 20 - 1;
> + totalmem = (sizeram() << 20) - 1;
>
I agree that it looks right, but it changes the answer, since subtraction
has a higher precedence than shift.

I don't have a board to test which is right.  Did you check v3?

Thanks,
Myles
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://www.coreboot.org/pipermail/coreboot/attachments/20100414/fa917f75/attachment.html>