[coreboot] [PATCH] clarify << and -

[Stefan Reinauer]

On 4/14/10 6:44 PM, Myles Watson wrote:
>
>     Index: src/northbridge/amd/gx2/chipsetinit.c
>     ===================================================================
>     --- src/northbridge/amd/gx2/chipsetinit.c (revision 5425)
>     +++ src/northbridge/amd/gx2/chipsetinit.c (working copy)
>     @@ -275,7 +275,7 @@
>     if ((msr.lo&0xff) == 0x11)
>     return;
>
>     - totalmem = sizeram() << 20 - 1;
>     + totalmem = (sizeram() << 20) - 1;
>
> I agree that it looks right, but it changes the answer, since
> subtraction has a higher precedence than shift.
>
> I don't have a board to test which is right.  Did you check v3?
Nor do I...

v3 never supported gx2.

-- 
coresystems GmbH . Brahmsstr. 16 . D-79104 Freiburg i. Br.
      Tel.: +49 761 7668825 . Fax: +49 761 7664613
Email: info at coresystems.de  . http://www.coresystems.de/
Registergericht: Amtsgericht Freiburg . HRB 7656
Geschäftsführer: Stefan Reinauer . Ust-IdNr.: DE245674866

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://www.coreboot.org/pipermail/coreboot/attachments/20100414/e997c8ca/attachment.html>