[coreboot] [PATCH] clarify << and -

Stefan Reinauer stepan at coresystems.de
Wed Apr 14 22:41:00 CEST 2010


On 4/14/10 9:35 PM, Myles Watson wrote:
>
>
> On Wed, Apr 14, 2010 at 1:22 PM, Stefan Reinauer
> <stepan at coresystems.de <mailto:stepan at coresystems.de>> wrote:
>
>     On 4/14/10 6:44 PM, Myles Watson wrote:
>>
>>         Index: src/northbridge/amd/gx2/chipsetinit.c
>>         ===================================================================
>>         --- src/northbridge/amd/gx2/chipsetinit.c (revision 5425)
>>         +++ src/northbridge/amd/gx2/chipsetinit.c (working copy)
>>         @@ -275,7 +275,7 @@
>>         if ((msr.lo&0xff) == 0x11)
>>         return;
>>
>>         - totalmem = sizeram() << 20 - 1;
>>         + totalmem = (sizeram() << 20) - 1;
>>
>>     I agree that it looks right, but it changes the answer, since
>>     subtraction has a higher precedence than shift.
>>
>>     I don't have a board to test which is right.  Did you check v3?
>     Nor do I...
>
>     v3 never supported gx2.
>
>
> I guess this should be the patch, then:
>
> - totalmem = sizeram() << 20 - 1;
> + totalmem = sizeram() << (20 - 1);
If we can't decide on the right fix we should leave the warning there as
it keeps the question open until someone can answer it.


-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://www.coreboot.org/pipermail/coreboot/attachments/20100414/9de402d0/attachment.html>


More information about the coreboot mailing list