[coreboot] [commit] r5451 - in trunk/util/vgabios: . include/console

[Myles Watson]

On Fri, Apr 16, 2010 at 4:49 PM, Stefan Reinauer <stepan at coresystems.de>wrote:

> On 4/16/10 2:43 PM, Myles Watson wrote:
> >> Modified: trunk/util/vgabios/include/console/console.h
> >>
> ==========================================================================
> >> ====
> >> --- trunk/util/vgabios/include/console/console.h     Fri Apr 16 03:45:44
> >> 2010 (r5450)
> >> +++ trunk/util/vgabios/include/console/console.h     Fri Apr 16 13:45:16
> >> 2010 (r5451)
> >> @@ -1,3 +1,4 @@
> >>  #ifndef _CONSOLE_CONSOLE_H
> >>  #define _CONSOLE_CONSOLE_H
> >> +#define CONFIG_X86EMU_DEBUG 1
> >>
> > If this is a config variable it should be set in Kconfig.  If it isn't,
> it
> > should probably have a different name.
>
> It's a utility completely independent of coreboot (well, supposed to
> be), just sharing some code. So I think it should not depend on the
> coreboot Kconfig. But I didn't want to add a separate Kconfig build
> system either, so I just hard coded the one variable...
>

Sorry about that.  I should have looked more closely at the path.  Since
x86_emu used to be in util ...

Thanks for straightening me out,
Myles
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://www.coreboot.org/pipermail/coreboot/attachments/20100416/8bc51886/attachment.html>