[coreboot] [commit] r5458 ...

[Stefan Reinauer]

On 4/19/10 11:21 PM, repository service wrote:
> The following hardware doesn't work:
>         4x NIC          21143-PD
>         2x PCMCIA       PCI1225PDV
>   
No surprise.. there seems to be no mptable and a possibly incomplete
pirq table.

> +    device pci 0d.0 on end		# NIC (DEC DECchip 21142/43)
> +    device pci 0e.0 on end		# NIC (DEC DECchip 21142/43)
> +    device pci 0f.0 on end		# CardBus bridge (TI PCI1225)
> +    device pci 0f.1 on end		# CardBus bridge (TI PCI1225)
>   
These should go away

> +  end
> +  device pci_domain 1 on		# PCI domain 1
> +    device pci 00.0 on end		# PCI bridge (DEC DECchip 21150)
> +  end
> +  device pci_domain 2 on		# PCI domain 2
> +    device pci 04.0 on end		# NIC (DECchip 21142/43)
> +    device pci 04.0 on end		# NIC (DECchip 21142/43)
> +  end
> +end
> +
>   
This is definitely wrong.. There's only one PCI domain on the 440bx. (on
all x86 systems without MMCONFIG actually)
Also, plugin cards and cards without "drivers" in coreboot don't need to
be mentioned in devicetree.cb (and shouldn't!)

> +		/* bus,        dev | fn,   {link, bitmap}, {link, bitmap}, {link, bitmap}, {link, bitmap}, slot, rfu */
> +		{0x00, (0x07 << 3) | 0x0, {{0x00, 0x0ea8}, {0x00, 0x0ea8}, {0x00, 0x0ea8}, {0x63, 0x0ea8}}, 0x0, 0x0},
> +		{0x00, (0x0c << 3) | 0x0, {{0x61, 0x06a8}, {0x62, 0x06a8}, {0x00, 0x06a8}, {0x00, 0x06a8}}, 0x0, 0x0},
> +		{0x00, (0x0d << 3) | 0x0, {{0x60, 0x0ea8}, {0x61, 0x0ea8}, {0x00, 0x0ea8}, {0x00, 0x0ea8}}, 0x1, 0x0},
> +		{0x00, (0x09 << 3) | 0x0, {{0x62, 0x0ea8}, {0x63, 0x0ea8}, {0x60, 0x0ea8}, {0x61, 0x0ea8}}, 0x2, 0x0},
> +		{0x00, (0x0a << 3) | 0x0, {{0x63, 0x0ea8}, {0x00, 0x0ea8}, {0x00, 0x0ea8}, {0x00, 0x0ea8}}, 0x0, 0x0},
> +		{0x01, (0x00 << 3) | 0x0, {{0x60, 0x0ea8}, {0x00, 0x0ea8}, {0x00, 0x0ea8}, {0x00, 0x0ea8}}, 0x0, 0x0},
>   
Which devices are this? Adding a comment might make it easier to fix it.
Also, I think you need to have an mptable _or_ program the 8259 and the
PCI devices' interrupt registers in order to get interrupts working.

Stefan