[coreboot] [commit] r5459 - in trunk/src: mainboard/arima/hdama mainboard/iwill/dk8s2 mainboard/iwill/dk8x mainboard/newisys/khepri northbridge/amd/amdfam10 northbridge/amd/amdk8 southbridge/amd/sb600 southbr...
repository service
svn at coreboot.org
Tue Apr 20 13:03:41 CEST 2010
Author: stepan
Date: Tue Apr 20 13:03:41 2010
New Revision: 5459
URL: https://tracker.coreboot.org/trac/coreboot/changeset/5459
Log:
As Myles suggested a while back: Switch long time #warnings to be comments
only. Keeping them as #warnings will not likely that they're fixed.
Signed-off-by: Stefan Reinauer <stepan at coresystems.de>
Acked-by: Stefan Reinauer <stepan at coresystems.de>
Modified:
trunk/src/mainboard/arima/hdama/mptable.c
trunk/src/mainboard/iwill/dk8s2/mptable.c
trunk/src/mainboard/iwill/dk8x/mptable.c
trunk/src/mainboard/newisys/khepri/mptable.c
trunk/src/northbridge/amd/amdfam10/northbridge.c
trunk/src/northbridge/amd/amdk8/northbridge.c
trunk/src/northbridge/amd/amdk8/raminit_f.c
trunk/src/southbridge/amd/sb600/sb600_early_setup.c
trunk/src/southbridge/amd/sb700/sb700_early_setup.c
Modified: trunk/src/mainboard/arima/hdama/mptable.c
==============================================================================
--- trunk/src/mainboard/arima/hdama/mptable.c Mon Apr 19 23:21:54 2010 (r5458)
+++ trunk/src/mainboard/arima/hdama/mptable.c Tue Apr 20 13:03:41 2010 (r5459)
@@ -295,14 +295,14 @@
smp_write_intsrc(mc, mp_INT, MP_IRQ_TRIGGER_DEFAULT|MP_IRQ_POLARITY_DEFAULT, bus_8131_1, (0x02<<2)|3, apicid_8111, 0x11);
/* PCI Slot 5 */
-#warning "FIXME get the irqs right, it's just hacked to work for now"
+ // FIXME get the irqs right, it's just hacked to work for now
smp_write_intsrc(mc, mp_INT, MP_IRQ_TRIGGER_DEFAULT|MP_IRQ_POLARITY_DEFAULT, bus_8111_1, (0x05<<2)|0, apicid_8111, 0x11);
smp_write_intsrc(mc, mp_INT, MP_IRQ_TRIGGER_DEFAULT|MP_IRQ_POLARITY_DEFAULT, bus_8111_1, (0x05<<2)|1, apicid_8111, 0x12);
smp_write_intsrc(mc, mp_INT, MP_IRQ_TRIGGER_DEFAULT|MP_IRQ_POLARITY_DEFAULT, bus_8111_1, (0x05<<2)|2, apicid_8111, 0x13);
smp_write_intsrc(mc, mp_INT, MP_IRQ_TRIGGER_DEFAULT|MP_IRQ_POLARITY_DEFAULT, bus_8111_1, (0x05<<2)|3, apicid_8111, 0x10);
/* PCI Slot 6 */
-#warning "FIXME get the irqs right, it's just hacked to work for now"
+ // FIXME get the irqs right, it's just hacked to work for now
smp_write_intsrc(mc, mp_INT, MP_IRQ_TRIGGER_DEFAULT|MP_IRQ_POLARITY_DEFAULT, bus_8111_1, (0x04<<2)|0, apicid_8111, 0x10);
smp_write_intsrc(mc, mp_INT, MP_IRQ_TRIGGER_DEFAULT|MP_IRQ_POLARITY_DEFAULT, bus_8111_1, (0x04<<2)|1, apicid_8111, 0x11);
smp_write_intsrc(mc, mp_INT, MP_IRQ_TRIGGER_DEFAULT|MP_IRQ_POLARITY_DEFAULT, bus_8111_1, (0x04<<2)|2, apicid_8111, 0x12);
Modified: trunk/src/mainboard/iwill/dk8s2/mptable.c
==============================================================================
--- trunk/src/mainboard/iwill/dk8s2/mptable.c Mon Apr 19 23:21:54 2010 (r5458)
+++ trunk/src/mainboard/iwill/dk8s2/mptable.c Tue Apr 20 13:03:41 2010 (r5459)
@@ -186,7 +186,7 @@
bus_8131_1, (2<<2)|3, 0x02, 0x11);
/* PCI Slot 5 */
-#warning "FIXME get the irqs right, it's just hacked to work for now"
+ // FIXME get the irqs right, it's just hacked to work for now
smp_write_intsrc(mc, mp_INT, MP_IRQ_TRIGGER_DEFAULT|MP_IRQ_POLARITY_DEFAULT,
bus_8111_1, (5<<2)|0, 0x02, 0x11);
smp_write_intsrc(mc, mp_INT, MP_IRQ_TRIGGER_DEFAULT|MP_IRQ_POLARITY_DEFAULT,
@@ -197,7 +197,7 @@
bus_8111_1, (5<<2)|3, 0x02, 0x10);
/* PCI Slot 6 */
-#warning "FIXME get the irqs right, it's just hacked to work for now"
+ // FIXME get the irqs right, it's just hacked to work for now
smp_write_intsrc(mc, mp_INT, MP_IRQ_TRIGGER_DEFAULT|MP_IRQ_POLARITY_DEFAULT,
bus_8111_1, (4<<2)|0, 0x02, 0x10);
smp_write_intsrc(mc, mp_INT, MP_IRQ_TRIGGER_DEFAULT|MP_IRQ_POLARITY_DEFAULT,
Modified: trunk/src/mainboard/iwill/dk8x/mptable.c
==============================================================================
--- trunk/src/mainboard/iwill/dk8x/mptable.c Mon Apr 19 23:21:54 2010 (r5458)
+++ trunk/src/mainboard/iwill/dk8x/mptable.c Tue Apr 20 13:03:41 2010 (r5459)
@@ -186,7 +186,7 @@
bus_8131_1, (2<<2)|3, 0x02, 0x11);
/* PCI Slot 5 */
-#warning "FIXME get the irqs right, it's just hacked to work for now"
+ // FIXME get the irqs right, it's just hacked to work for now
smp_write_intsrc(mc, mp_INT, MP_IRQ_TRIGGER_DEFAULT|MP_IRQ_POLARITY_DEFAULT,
bus_8111_1, (5<<2)|0, 0x02, 0x11);
smp_write_intsrc(mc, mp_INT, MP_IRQ_TRIGGER_DEFAULT|MP_IRQ_POLARITY_DEFAULT,
@@ -197,7 +197,7 @@
bus_8111_1, (5<<2)|3, 0x02, 0x10);
/* PCI Slot 6 */
-#warning "FIXME get the irqs right, it's just hacked to work for now"
+ // FIXME get the irqs right, it's just hacked to work for now
smp_write_intsrc(mc, mp_INT, MP_IRQ_TRIGGER_DEFAULT|MP_IRQ_POLARITY_DEFAULT,
bus_8111_1, (4<<2)|0, 0x02, 0x10);
smp_write_intsrc(mc, mp_INT, MP_IRQ_TRIGGER_DEFAULT|MP_IRQ_POLARITY_DEFAULT,
Modified: trunk/src/mainboard/newisys/khepri/mptable.c
==============================================================================
--- trunk/src/mainboard/newisys/khepri/mptable.c Mon Apr 19 23:21:54 2010 (r5458)
+++ trunk/src/mainboard/newisys/khepri/mptable.c Tue Apr 20 13:03:41 2010 (r5459)
@@ -187,7 +187,7 @@
bus_8131_1, (2<<2)|3, 0x02, 0x11);
/* PCI Slot 5 */
-#warning "FIXME get the irqs right, it's just hacked to work for now"
+ // FIXME get the irqs right, it's just hacked to work for now
smp_write_intsrc(mc, mp_INT, MP_IRQ_TRIGGER_DEFAULT|MP_IRQ_POLARITY_DEFAULT,
bus_8111_1, (5<<2)|0, 0x02, 0x11);
smp_write_intsrc(mc, mp_INT, MP_IRQ_TRIGGER_DEFAULT|MP_IRQ_POLARITY_DEFAULT,
@@ -198,7 +198,7 @@
bus_8111_1, (5<<2)|3, 0x02, 0x10);
/* PCI Slot 6 */
-#warning "FIXME get the irqs right, it's just hacked to work for now"
+ // FIXME get the irqs right, it's just hacked to work for now
smp_write_intsrc(mc, mp_INT, MP_IRQ_TRIGGER_DEFAULT|MP_IRQ_POLARITY_DEFAULT,
bus_8111_1, (4<<2)|0, 0x02, 0x10);
smp_write_intsrc(mc, mp_INT, MP_IRQ_TRIGGER_DEFAULT|MP_IRQ_POLARITY_DEFAULT,
Modified: trunk/src/northbridge/amd/amdfam10/northbridge.c
==============================================================================
--- trunk/src/northbridge/amd/amdfam10/northbridge.c Mon Apr 19 23:21:54 2010 (r5458)
+++ trunk/src/northbridge/amd/amdfam10/northbridge.c Tue Apr 20 13:03:41 2010 (r5459)
@@ -960,12 +960,14 @@
pci_tolm = find_pci_tolm(&dev->link[link], pci_tolm);
}
-#warning "FIXME handle interleaved nodes"
+ // FIXME handle interleaved nodes. If you fix this here, please fix
+ // amdk8, too.
mmio_basek = pci_tolm >> 10;
/* Round mmio_basek to something the processor can support */
mmio_basek &= ~((1 << 6) -1);
-#warning "FIXME improve mtrr.c so we don't use up all of the mtrrs with a 64M MMIO hole"
+ // FIXME improve mtrr.c so we don't use up all of the mtrrs with a 64M
+ // MMIO hole. If you fix this here, please fix amdk8, too.
/* Round the mmio hold to 64M */
mmio_basek &= ~((64*1024) - 1);
Modified: trunk/src/northbridge/amd/amdk8/northbridge.c
==============================================================================
--- trunk/src/northbridge/amd/amdk8/northbridge.c Mon Apr 19 23:21:54 2010 (r5458)
+++ trunk/src/northbridge/amd/amdk8/northbridge.c Tue Apr 20 13:03:41 2010 (r5459)
@@ -915,19 +915,18 @@
}
#endif
-
pci_tolm = find_pci_tolm(&dev->link[0]);
-#warning "FIXME handle interleaved nodes"
+ // FIXME handle interleaved nodes. If you fix this here, please fix
+ // amdfam10, too.
mmio_basek = pci_tolm >> 10;
/* Round mmio_basek to something the processor can support */
mmio_basek &= ~((1 << 6) -1);
-#if 1
-#warning "FIXME improve mtrr.c so we don't use up all of the mtrrs with a 64M MMIO hole"
+ // FIXME improve mtrr.c so we don't use up all of the mtrrs with a 64M
+ // MMIO hole. If you fix this here, please fix amdfam10, too.
/* Round the mmio hole to 64M */
mmio_basek &= ~((64*1024) - 1);
-#endif
#if CONFIG_HW_MEM_HOLE_SIZEK != 0
/* if the hw mem hole is already set in raminit stage, here we will compare mmio_basek and hole_basek
Modified: trunk/src/northbridge/amd/amdk8/raminit_f.c
==============================================================================
--- trunk/src/northbridge/amd/amdk8/raminit_f.c Mon Apr 19 23:21:54 2010 (r5458)
+++ trunk/src/northbridge/amd/amdk8/raminit_f.c Tue Apr 20 13:03:41 2010 (r5459)
@@ -1964,9 +1964,9 @@
printk_raminit("update_dimm_Trc: clocks = %i\n", clocks);
if (clocks < DTL_TRC_MIN) {
-#warning We should die here or at least disable this bank.
- printk(BIOS_NOTICE, "update_dimm_Trc: can't refresh fast enough, "
- "want %i clocks, can %i clocks\n", clocks, DTL_TRC_MIN);
+ // We might want to die here instead or (at least|better) disable this bank.
+ printk(BIOS_NOTICE, "update_dimm_Trc: Can't refresh fast enough, "
+ "want %i clocks, minimum is %i clocks.\n", clocks, DTL_TRC_MIN);
clocks = DTL_TRC_MIN;
}
return clocks;
Modified: trunk/src/southbridge/amd/sb600/sb600_early_setup.c
==============================================================================
--- trunk/src/southbridge/amd/sb600/sb600_early_setup.c Mon Apr 19 23:21:54 2010 (r5458)
+++ trunk/src/southbridge/amd/sb600/sb600_early_setup.c Tue Apr 20 13:03:41 2010 (r5459)
@@ -88,7 +88,7 @@
dev = pci_locate_device(PCI_ID(0x1002, 0x438d), 0); /* LPC Controller */
/* Decode port 0x3f8-0x3ff (Serial 0) */
-#warning Serial port decode on LPC is hardcoded to 0x3f8
+ // XXX Serial port decode on LPC is hardcoded to 0x3f8
reg8 = pci_read_config8(dev, 0x44);
reg8 |= 1 << 6;
pci_write_config8(dev, 0x44, reg8);
Modified: trunk/src/southbridge/amd/sb700/sb700_early_setup.c
==============================================================================
--- trunk/src/southbridge/amd/sb700/sb700_early_setup.c Mon Apr 19 23:21:54 2010 (r5458)
+++ trunk/src/southbridge/amd/sb700/sb700_early_setup.c Tue Apr 20 13:03:41 2010 (r5459)
@@ -119,7 +119,7 @@
dev = pci_locate_device(PCI_ID(0x1002, 0x439d), 0); /* LPC Controller */
/* Decode port 0x3f8-0x3ff (Serial 0) */
-#warning Serial port decode on LPC is hardcoded to 0x3f8
+ // XXX Serial port decode on LPC is hardcoded to 0x3f8
reg8 = pci_read_config8(dev, 0x44);
reg8 |= 1 << 6;
pci_write_config8(dev, 0x44, reg8);
More information about the coreboot
mailing list