[coreboot] [commit] r5680 - in trunk/src: northbridge/intel/i82830 northbridge/via/cn400 northbridge/via/cn700 northbridge/via/cx700 northbridge/via/vt8623 northbridge/via/vx800 southbridge/amd/cs5530

Stefan Reinauer stefan.reinauer at coresystems.de
Tue Aug 3 11:34:27 CEST 2010


 On 8/2/10 5:14 PM, repository service wrote:
> Author: myles
> Date: Mon Aug  2 17:14:13 2010
> New Revision: 5680
> URL: https://tracker.coreboot.org/trac/coreboot/changeset/5680
>
> Log:
> Build VGA code conditionally to avoid errors when using SeaBIOS.
>
> Signed-off-by: Myles Watson <mylesgw at gmail.com>
> Acked-by: Kevin O'Connor <kevin at koconnor.net>
>
> Modified:
>    trunk/src/northbridge/intel/i82830/Makefile.inc
>    trunk/src/northbridge/via/cn400/Makefile.inc
>    trunk/src/northbridge/via/cn700/Makefile.inc
>    trunk/src/northbridge/via/cx700/Makefile.inc
>    trunk/src/northbridge/via/vt8623/Makefile.inc
>    trunk/src/northbridge/via/vx800/Makefile.inc
>    trunk/src/southbridge/amd/cs5530/Makefile.inc

I'm not too happy with this change.

- cs5530 is not using the option rom init code at all but does a lot of
other things (that might be needed as a prerequisite for running SeaBIOS)
- the change definitely breaks the i82830 MBI code
- vga init on cn400 sets the framebuffer size in addition to calling the
vga option rom (plus a lot of other things)
- vga init on cn700 sets the framebuffer size in addition to calling the
vga option rom (plus a lot of other things)
- vt8623 does some "random fixup" too.

So I assume at least some of the targets will not behave correctly
anymore when VGA oproms are disabled (and implicitly not executing the
non-oprom parts when oprom execution is disabled sounds like the wrong
thing to do)

Stefan




More information about the coreboot mailing list