[coreboot] mainboard.c: init() still being called?

Myles Watson mylesgw at gmail.com
Mon Aug 16 18:28:03 CEST 2010


On Mon, Aug 16, 2010 at 10:15 AM, Stefan Reinauer
<stefan.reinauer at coresystems.de> wrote:
> On 8/16/10 6:11 PM, Stefan Reinauer wrote:
>
> On 8/16/10 5:11 PM, Myles Watson wrote:
>
> Index: src/devices/device.c
> ===================================================================
> --- src/devices/device.c	(revision 5692)
> +++ src/devices/device.c	(working copy)
> @@ -1104,6 +1104,9 @@
>
>  	printk(BIOS_INFO, "Initializing devices...\n");
>
> +	/* First call the mainboard init. */
> +	init_dev(&dev_root);
> +
>  	/* now initialize everything. */
>  	for (link = dev_root.link_list; link; link = link->next)
>  		init_link(link);
>
> Acked-by: Stefan Reinauer <stepan at coresystems.de>
Rev 5698.

> Do we need a similar workaround for the enable_dev() call?
It's already there.  I think init() just got missed because so few
boards use it.

Thanks,
Myles




More information about the coreboot mailing list