[coreboot] [inteltool] added initial support of CPU extended information and non-Intel CPU's

[Stefan Reinauer]

 On 8/25/10 7:34 PM, Антон Кочков wrote:
> inteltool: added initial support of cpu_info extended information
> inteltool: added initial support for other cpu's
> inteltool: dumping MSR registers for Intel Celeron M 743
> Signed-off-by: Anton Kochkov <anton.kochkov at gmail.com>
Hi Anton,

just some thoughts...

I don't think we should add parsing of CPUID features into inteltool
because there are excellent tools for Linux doing an excellent job
already, like Dave Jones' x86info.
See http://www.codemonkey.org.uk/projects/x86info/ for more information.

Also, EPBAR, DMIBAR, MCHBAR, etc are very intel specific terms, so it
will be hard to add support for other chipset vendors without making the
tool (unnecessarily?) complex.
I'd like to hear from other people on this issue, though...

As for the CPUID part, I don't think that all CPUs with 0x10670 are
Intel Celeron M 743 1.3 GHz. There might be other Celeron Ms with that
ID too. Also, I think the supported MSRs are different between the Core
2 Duo (6fx) and Celeron M (10670)

Stefan